Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): fix timezone error when getting new year by new Date #19454

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Dec 31, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the timezone error when getting new year by new Date

#19453

https://github.com/apache/echarts/actions/runs/7371451106/job/20058853427#step:3:1

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Dec 31, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart requested a review from pissang December 31, 2023 16:24
@plainheart
Copy link
Member Author

@pissang Please help review again. Sorry for the mistake.

@plainheart plainheart merged commit f1d9eb5 into master Jan 1, 2024
2 checks passed
Copy link

echarts-bot bot commented Jan 1, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/workflow/update-notice-year branch January 1, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants